Conversation
smarnach
force-pushed
the
uv
branch
2 times, most recently
from
64bb169 to
25371ae
Compare
biancadanforth
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates obs-common to uv. Some of the changes are similar to what I did for our services, but a lot of this is different since this is a library and not a service application.
With this PR, uv replaces pip, pip-tools, setuptools, setuptools-scm and twine.
I decided to exclude uv.lock from this repository. Including the lock file improves the consistency of CI, but adds a lot of overhead with Dependabot upgrades – see the Jira ticket for more details. I went back and forth on whether to stick with setuptools or use uv's own build backend. I eventually figured out that the latter is overall simpler and faster, so this is what I went with.
The Dockerfile changes were only lightly tested since I plan to drop the main Dockerfile and the devcontainer setup in a follow-up PR (https://mozilla-hub.atlassian.net/browse/CRINGE-225). I tried testing the GAR upload code locally to the degree that's possible, but we'll only figure out whether it's actually working once we merge this PR into the main branch.
https://mozilla-hub.atlassian.net/browse/CRINGE-210